On Jun 6 2007 11:05, Jesper Juhl wrote: > > - Source files should be 7bit ASCII
Nah. Think of.... MODULE_AUTHOR("J. Ørsted <[EMAIL PROTECTED]>"); > - Maybe warn about usage of float/double in source files? Generally yes, maybe, but see arch/i386/kernel/cpu/bugs.c, arch/i386/math-emu/. Generally there is nothing to it. I think the feature to allow the kernel to use [i387] FP without manually saving/restoring the FP stack has been added some time ago. > - 'return' is not a function, so warn about patches that think it is > and use 'return(expr);' (this one is tricky since 'return (expr);' can > be OK in some cases. Now, if we could detect superfluous parentheses and branches, that'd be cool ;-) there are too many if ((a < 5) || (b > 6)) around. Jan --