On 19 April 2018 at 12:40, Enric Balletbo i Serra
<enric.balle...@collabora.com> wrote:
> From: Lin Huang <h...@rock-chips.com>
>
> We just return -EPROBE_DEFER error code to caller and do not
> print error message when try to get center logic regulator
> and DMC clock defer.
>
> Signed-off-by: Lin Huang <h...@rock-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> ---
>
> drivers/devfreq/rk3399_dmc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 44a379657cd5..5bfca028eaaf 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -308,12 +308,18 @@ static int rk3399_dmcfreq_probe(struct platform_device
> *pdev)
>
> data->vdd_center = devm_regulator_get(dev, "center");
> if (IS_ERR(data->vdd_center)) {
> + if (PTR_ERR(data->vdd_center) == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> dev_err(dev, "Cannot get the regulator \"center\"\n");
Doesn't the clock core already print an error message for this?
Maybe a better way is simply to drop the printing instead of trying to
have a special case for it?
> return PTR_ERR(data->vdd_center);
> }
>
> data->dmc_clk = devm_clk_get(dev, "dmc_clk");
> if (IS_ERR(data->dmc_clk)) {
> + if (PTR_ERR(data->dmc_clk) == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> dev_err(dev, "Cannot get the clk dmc_clk\n");
> return PTR_ERR(data->dmc_clk);
> };
> --
> 2.17.0
>
Kind regards
Uffe
