Re: [PATCH v4] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().

[Mark Brown]

On Wed, Apr 25, 2018 at 06:49:06PM +0200, Stefan Potyra wrote:

> Additionally, prepare/enable the pll_clk before calling clk_get_rate()
> for the same reason.

I don't see this change in the code:

>               struct clk *pll_clk = devm_clk_get(dev, "pll");
>  
> -             if (IS_ERR(pll_clk))
> -                     return PTR_ERR(pll_clk);
> +             if (IS_ERR(pll_clk)) {
> +                     ret = PTR_ERR(pll_clk);
> +                     goto out_disable_clk;
> +             }
> +
>  
>               rate = clk_get_rate(pll_clk);
> -             if (!rate)
> -                     return -EINVAL;

Did you forget a git add?

signature.asc
Description: PGP signature