On Wed, Apr 25, 2018 at 01:25:26PM -0500, Rob Herring wrote: > On Tue, Apr 24, 2018 at 11:34 AM, Johan Hovold <[email protected]> wrote: > > Add binding for SiRFstar-based GNSS receivers. > > > > Note that while four compatible-strings are initially added representing > > devices which differ in which I/O interfaces they support, they > > otherwise essentially share the same feature set. > > > > Pin and supply names (and some recommended timings) vary slightly, but > > the binding recommends using a common set of names. > > > > Note that the wakeup gpio is not intended to be as a wakeup source, but > > rather to detect the current power state of the device (active or > > hibernate). > > > > Signed-off-by: Johan Hovold <[email protected]> > > --- > > .../devicetree/bindings/gnss/sirfstar.txt | 38 +++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.txt | 3 ++ > > 2 files changed, 41 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gnss/sirfstar.txt > > One nit below, otherwise: > > Reviewed-by: Rob Herring <[email protected]>
> > @@ -390,6 +392,7 @@ vivante Vivante Corporation > > vocore VoCore Studio > > voipac Voipac Technologies s.r.o. > > vot Vision Optical Technology Co., Ltd. > > +wi2wi Wi2Wi > > Wrong spot. Duh. I had first misspelled this w2wi (which happens to be a different company), and then forgot to move the entry when I corrected my mistake. > > wd Western Digital Corp. > > wetek WeTek Electronics, limited. > > wexler Wexler Thanks, Johan
