On Thu, 2018-04-26 at 16:44 +0800, Yixun Lan wrote:
> There is a protential memory leak, as of_clk_del_provider is
> never called if of_clk_add_hw_provider has been executed.
> Fix this by using devm variant API.
> 
> Fixes: f8c11f79912d ("clk: meson: Add GXBB AO Clock and Reset controller 
> driver")
> Suggested-by: Stephen Boyd <sb...@kernel.org>
> Signed-off-by: Yixun Lan <yixun....@amlogic.com>
> ---
>  drivers/clk/meson/gxbb-aoclk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/gxbb-aoclk.c b/drivers/clk/meson/gxbb-aoclk.c
> index 9ec23ae9a219..eebb580b9e0f 100644
> --- a/drivers/clk/meson/gxbb-aoclk.c
> +++ b/drivers/clk/meson/gxbb-aoclk.c
> @@ -191,7 +191,7 @@ static int gxbb_aoclkc_probe(struct platform_device *pdev)
>       if (ret)
>               return ret;
>  
> -     return of_clk_add_hw_provider(dev->of_node, of_clk_hw_onecell_get,
> +     return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
>                       &gxbb_aoclk_onecell_data);
>  }
>  

Applied
Thx

Reply via email to