Re: [PATCH v2 3/3] lightnvm: pblk: fix smeta write error path

[Javier Gonzalez]

> On 24 Apr 2018, at 07.45, Hans Holmberg <hans.ml.holmb...@owltronix.com> 
> wrote:
> 
> From: Hans Holmberg <hans.holmb...@cnexlabs.com>
> 
> Smeta write errors were previously ignored. Skip these
> lines instead and throw them back on the free
> list, so the chunks will go through a reset cycle
> before we attempt to use the line again.
> 
> Signed-off-by: Hans Holmberg <hans.holmb...@cnexlabs.com>
> ---
> drivers/lightnvm/pblk-core.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 413cf3b..dec1bb4 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -849,9 +849,10 @@ static int pblk_line_submit_smeta_io(struct pblk *pblk, 
> struct pblk_line *line,
>       atomic_dec(&pblk->inflight_io);
> 
>       if (rqd.error) {
> -             if (dir == PBLK_WRITE)
> +             if (dir == PBLK_WRITE) {
>                       pblk_log_write_err(pblk, &rqd);
> -             else if (dir == PBLK_READ)
> +                     ret = 1;
> +             } else if (dir == PBLK_READ)
>                       pblk_log_read_err(pblk, &rqd);
>       }
> 
> @@ -1120,7 +1121,7 @@ static int pblk_line_init_bb(struct pblk *pblk, struct 
> pblk_line *line,
> 
>       if (init && pblk_line_submit_smeta_io(pblk, line, off, PBLK_WRITE)) {
>               pr_debug("pblk: line smeta I/O failed. Retry\n");
> -             return 1;
> +             return 0;
>       }
> 
>       bitmap_copy(line->invalid_bitmap, line->map_bitmap, lm->sec_per_line);
> --
> 2.7.4

LGTM

Reviewed-by: Javier González <jav...@cnexlabs.com>

signature.asc
Description: Message signed with OpenPGP