On Mon, 30 Apr 2018, Jani Nikula wrote:
> On Wed, 25 Apr 2018, Daniel Vetter <daniel.vet...@ffwll.ch> wrote:
> > Now that the 3 drivers using this are cleaned up we can also remove
> > this final bit of confusion of leaking driver internals into the
> > backlight power interface.
> >
> > The backlight power interface itself is still a massive mess.
> >
> > Cc: Lee Jones <lee.jo...@linaro.org>
> > Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> > Cc: Jingoo Han <jingooh...@gmail.com>
> > Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>
> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>
> > ---
> > include/linux/backlight.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> > index 1db67662bfcb..7fbf0539e14a 100644
> > --- a/include/linux/backlight.h
> > +++ b/include/linux/backlight.h
> > @@ -84,7 +84,6 @@ struct backlight_properties {
> >
> > #define BL_CORE_SUSPENDED (1 << 0) /* backlight is suspended */
> > #define BL_CORE_FBBLANK (1 << 1) /* backlight is under
> > an fb blank event */
> > -#define BL_CORE_DRIVER1 (1 << 31) /* reserved for driver
> > specific use */
>
> Please also remove the
>
> /* Upper 4 bits are reserved for driver internal use */
>
> comment a few lines up to not give anyone ideas.
>
> With that,
>
> Reviewed-by: Jani Nikula <jani.nik...@intel.com>
I'm merging these patches (with Jani's Acks) now.
Please send this request as a subsequent patch.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
