On Mon, Apr 30, 2018 at 02:22:59PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
> a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
> checks against *arg. This looks like an unintentional missing break so
> add in the break.
>
> Detected by CoverityScan, CID#1468456, 1468459 ("Missing break in switch")
>
Thanks for fixing!
> Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Manivannan Sadhasivam <[email protected]>
Thanks,
Mani
> ---
> drivers/pinctrl/actions/pinctrl-owl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.c
> b/drivers/pinctrl/actions/pinctrl-owl.c
> index 928b40f71a3c..ee090697b1e9 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.c
> +++ b/drivers/pinctrl/actions/pinctrl-owl.c
> @@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct
> owl_pingroup *g,
> default:
> return -EINVAL;
> }
> + break;
> case PIN_CONFIG_SLEW_RATE:
> if (*arg)
> *arg = OWL_PINCONF_SLEW_FAST;
> @@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct
> owl_pingroup *g,
> default:
> return -EINVAL;
> }
> + break;
> case PIN_CONFIG_SLEW_RATE:
> if (*arg)
> *arg = 1;
> --
> 2.17.0
>
