On Wed, May 02, 2018 at 03:39:19AM +0800, kbuild test robot wrote:
> Hi Guenter,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on tip/auto-latest]
> [also build test ERROR on v4.17-rc3 next-20180501]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Guenter-Roeck/x86-amd_nb-Add-support-for-Raven-Ridge-CPUs/20180502-024535
> config: i386-randconfig-x016-201817 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> drivers/hwmon/k10temp.c: In function 'read_tempreg_nb_f17':
> >> drivers/hwmon/k10temp.c:126:15: error: implicit declaration of function
> >> 'amd_pci_dev_to_node_id'; did you mean 'pci_set_of_node'?
> >> [-Werror=implicit-function-declaration]
> amd_smn_read(amd_pci_dev_to_node_id(pdev),
> ^~~~~~~~~~~~~~~~~~~~~~
> pci_set_of_node
> cc1: some warnings being treated as errors
>
What would we do without 0day. The driver needs to depend on CONFIG_AMD_NB,
which makes sense anyway. I'll add that dependency in v3.
Guenter
> vim +126 drivers/hwmon/k10temp.c
>
> 123
> 124 static void read_tempreg_nb_f17(struct pci_dev *pdev, u32
> *regval)
> 125 {
> > 126 amd_smn_read(amd_pci_dev_to_node_id(pdev),
> 127 F17H_M01H_REPORTED_TEMP_CTRL_OFFSET,
> regval);
> 128 }
> 129
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
