From: Arnaldo Carvalho de Melo <a...@redhat.com>

map->type is going away, we can derive it from map->prot, so use
the same logic as in the kernel's arch/arm/kernel/module.c file:

  ELF32_ST_TYPE(sym->st_info) == STT_FUNC && !(sym->st_value & 1))

This was introduced in b2f8fb237e9c ("perf symbols: Fix annotation of
thumb code"), that fix is maintained with this change.

Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: Dave Martin <dave.mar...@linaro.org>
Cc: David Ahern <dsah...@gmail.com>
Cc: Dr. David Alan Gilbert <david.gilb...@linaro.org>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Link: https://lkml.kernel.org/n/tip-us590h81uqgxaumucfttq...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/util/symbol-elf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index cf2e6f428bb4..82a1aadc245f 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -982,7 +982,7 @@ int dso__load_sym(struct dso *dso, struct map *map, struct 
symsrc *syms_ss,
                /* On ARM, symbols for thumb functions have 1 added to
                 * the symbol address as a flag - remove it */
                if ((ehdr.e_machine == EM_ARM) &&
-                   (map->type == MAP__FUNCTION) &&
+                   (GELF_ST_TYPE(sym.st_info) == STT_FUNC) &&
                    (sym.st_value & 1))
                        --sym.st_value;
 
-- 
2.14.3

Reply via email to