2018-05-02 20:30 GMT+09:00 Riku Voipio <[email protected]>: > On 23 April 2018 at 22:50, Mathieu Malaterre <[email protected]> wrote: >> Be nice to the user and check env vars KBUILD_BUILD_USER & >> KBUILD_BUILD_HOST when those are set. > > mkdebian sets the maintainer address as "$name <$email>", but this > patch only sets the email part. I also wonder about the precedence, I > think KBUILD_* should be considered over the generic Debian variables.
How come? If you see scripts/mkcompile_h, KBUILD_BUILD_USER and KBUILD_BUILD_HOST are used for overriding 'whoami' and 'hostname', respectively. So, I think it is reasonable to put email=$KBUILD_BUILD_USER@$KBUILD_BUILD_HOST over email=$(id -nu)@$(hostname -f 2>/dev/null || hostname) But, it is questionable to put it even over $DEBEMAIL. I think the intention of this patch is to support another (a bit better) fallback in case DEBEMAIL is not set. > Riku > >> Signed-off-by: Mathieu Malaterre <[email protected]> >> --- >> scripts/package/mkdebian | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian >> index 6adb3a16ba3b..05d58d3ae8a0 100755 >> --- a/scripts/package/mkdebian >> +++ b/scripts/package/mkdebian >> @@ -76,6 +76,8 @@ if [ -n "$DEBEMAIL" ]; then >> email=$DEBEMAIL >> elif [ -n "$EMAIL" ]; then >> email=$EMAIL >> +elif [ -n "$KBUILD_BUILD_USER" ] && [ -n "$KBUILD_BUILD_HOST" ]; then >> + email=$KBUILD_BUILD_USER@$KBUILD_BUILD_HOST >> else >> email=$(id -nu)@$(hostname -f 2>/dev/null || hostname) >> fi >> -- >> 2.11.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in >> the body of a message to [email protected] >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Masahiro Yamada
