On Sat, 24 Mar 2018 16:48:20 +0530 Arushi Singhal <[email protected]> wrote:
Subject prefix should be "mtd: devices: st_spi_fsm: ", and it's really about checking return code which was already propagated to the lower layer (platform bus), but it's about making sure we disable the clk we have previously enabled in case of failure. BTW, I see that the clk is not disabled in ->remove(), probably something we should fix too (in a separate patch). > stfsm_probe() misses error handling of mtd_device_register(). > > Signed-off-by: Arushi Singhal <[email protected]> > --- > drivers/mtd/devices/st_spi_fsm.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/devices/st_spi_fsm.c > b/drivers/mtd/devices/st_spi_fsm.c > index 7bc29d7..4a99a6a 100644 > --- a/drivers/mtd/devices/st_spi_fsm.c > +++ b/drivers/mtd/devices/st_spi_fsm.c > @@ -2125,7 +2125,13 @@ static int stfsm_probe(struct platform_device *pdev) > (long long)fsm->mtd.size, (long long)(fsm->mtd.size >> 20), > fsm->mtd.erasesize, (fsm->mtd.erasesize >> 10)); > > - return mtd_device_register(&fsm->mtd, NULL, 0); > + ret = mtd_device_register(&fsm->mtd, NULL, 0); > + if (ret) { > + pr_err("Failed to register device\n"); > + goto err_clk_unprepare; > + } > + > + return 0; > > err_clk_unprepare: > clk_disable_unprepare(fsm->clk);
