On Thu, May 3, 2018 at 1:54 AM Tobin C. Harding <to...@apporbit.com> wrote:
> This code was a pleasure to read, super clean. Hi Tobin, Thank you very much for your review, I will address all of your comments in the next revision. BTW, I found a lock ordering issue in my work that that I will need to fix: In device_shutdown() device_lock() must be taken before devices_kset->list_lock. Instead I will use device_trylock(), and if that fails, will drop devices_kset->list_lock and acquiring the device lock outside, and check that the device is still in the list after taking the list lock again. Pavel
