Re: [PATCH v2] serial: sh-sci: Use spin_{try}lock_irqsave instead of open coding version

[Daniel Wagner]

Hi Sebastian,

On 05/07/2018 02:51 PM, Sebastian Andrzej Siewior wrote:
On 2018-05-04 18:30:41 [+0200], Daniel Wagner wrote:
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2890,16 +2890,16 @@ static void serial_console_write(struct console *co, 
const char *s,
        unsigned long flags;
        int locked = 1;
  
-	local_irq_save(flags);
  #if defined(SUPPORT_SYSRQ)
-       if (port->sysrq)
+       if (port->sysrq) {
                locked = 0;
-       else
+               local_irq_save(flags);

how is this helping? You should see a splat after a sysrq request.

You are right, I didn't really think this through.

Should 'echo t > /proc/sysrq' trigger the splat? At least I was so naive 
that think it would be enough.

Thanks,
Daniel