On Tue, May 8, 2018 at 5:57 PM, Miklos Szeredi <[email protected]> wrote: > On Tue, May 8, 2018 at 7:14 AM, Amir Goldstein <[email protected]> wrote: >> On Mon, May 7, 2018 at 11:37 AM, Miklos Szeredi <[email protected]> wrote: >>> Implement stacked fsync(). >>> >>> Signed-off-by: Miklos Szeredi <[email protected]> >>> --- >>> fs/overlayfs/file.c | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c >>> index a7af56861aa5..419aa3f9967b 100644 >>> --- a/fs/overlayfs/file.c >>> +++ b/fs/overlayfs/file.c >>> @@ -233,10 +233,30 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, >>> struct iov_iter *iter) >>> return ret; >>> } >>> >>> +static int ovl_fsync(struct file *file, loff_t start, loff_t end, int >>> datasync) >>> +{ >>> + struct fd real; >>> + const struct cred *old_cred; >>> + int ret; >>> + >> >> Don't sync non-upper. same as ovl_dir_fsync() > > Ah, that was about EROFS returned by lower fsync, right? >
Yap. to reason to try and sync a lower file. Thanks, Amir.
