On 05/09/2018 04:17 PM, Jeffrin Jose T wrote: > fix for notification of permission requirement to run test. > fix for exit status value for test skipped. > > Signed-off-by: Jeffrin Jose T <[email protected]> > --- > tools/testing/selftests/intel_pstate/run.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/selftests/intel_pstate/run.sh > b/tools/testing/selftests/intel_pstate/run.sh > index c670359becc6..74983f74a9a1 100755 > --- a/tools/testing/selftests/intel_pstate/run.sh > +++ b/tools/testing/selftests/intel_pstate/run.sh > @@ -30,6 +30,13 @@ > > EVALUATE_ONLY=0 > > +msg="skip all tests:" > + > +if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then > + echo $msg please run this as root >&2 > + exit $ksft_skip > +fi > + > if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then > echo "$0 # Skipped: Test can only run on x86 architectures." > exit 0 >
I have a patch out for this and your change conflicts with it. I am in the process of pushing patches into linux-kselftest next. Please rebase this patch on top of that. thanks, -- Shuah
