On Sun, May 13, 2018 at 10:35:44AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdun...@infradead.org>
>
> Prevent build error when CONFIG_ACPI_NFIT=m and CONFIG_EDAC_SKX=y
> by limiting EDAC_SKX based on how ACPI_NFIT is set.
>
> Fixes this build error:
> drivers/edac/skx_edac.o: In function `get_nvdimm_info':
> ../drivers/edac/skx_edac.c:399: undefined reference to `nfit_get_smbios_id'
>
> Fixes: 58ca9ac1463d ("EDAC, skx_edac: Detect non-volatile DIMMs")
>
> Reported-by: kbuild test robot <l...@intel.com>
> Signed-off-by: Randy Dunlap <rdun...@infradead.org>
> Cc: Tony Luck <tony.l...@intel.com>
> Cc: Borislav Petkov <b...@alien8.de>
> Cc: Mauro Carvalho Chehab <mche...@kernel.org>
> Cc: sta...@vger.kernel.org
> ---
> drivers/edac/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> v2: add comment in Kconfig file
>
> --- lnx-417-rc4.orig/drivers/edac/Kconfig
> +++ lnx-417-rc4/drivers/edac/Kconfig
> @@ -232,6 +232,7 @@ config EDAC_SBRIDGE
> config EDAC_SKX
> tristate "Intel Skylake server Integrated MC"
> depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG
> + depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y
> select DMI
> help
> Support for error detection and correction the Intel
--
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
