[tip:perf/core] perf buildid-cache: Warn --purge-all failures

[tip-bot for Ravi Bangoria]

Commit-ID:  d8ed87bc171946313b2e6d26e1fec494da9154bc
Gitweb:     https://git.kernel.org/tip/d8ed87bc171946313b2e6d26e1fec494da9154bc
Author:     Ravi Bangoria <ravi.bango...@linux.ibm.com>
AuthorDate: Thu, 10 May 2018 10:06:51 +0530
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Tue, 15 May 2018 10:32:16 -0300

perf buildid-cache: Warn --purge-all failures

Warn perf buildid-cache --purge-all failures in non verbose mode.

Ex.:

  $ sudo chown root:root /home/ravi/.debug -R
  $ sudo chmod 700 /home/ravi/.debug/ -R
  $ ./perf buildid-cache -P
    Couldn't remove some caches. Error: Permission denied.

Suggested-by: Masami Hiramatsu <mhira...@kernel.org>
Signed-off-by: Ravi Bangoria <ravi.bango...@linux.ibm.com>
Acked-by: Masami Hiramatsu <mhira...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Link: 
http://lkml.kernel.org/r/20180510043651.12189-1-ravi.bango...@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/builtin-buildid-cache.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-buildid-cache.c 
b/tools/perf/builtin-buildid-cache.c
index 7a7403913b57..115110a4796a 100644
--- a/tools/perf/builtin-buildid-cache.c
+++ b/tools/perf/builtin-buildid-cache.c
@@ -488,8 +488,12 @@ int cmd_buildid_cache(int argc, const char **argv)
                }
        }
 
-       if (purge_all)
-               ret = build_id_cache__purge_all();
+       if (purge_all) {
+               if (build_id_cache__purge_all()) {
+                       pr_warning("Couldn't remove some caches. Error: %s.\n",
+                               str_error_r(errno, sbuf, sizeof(sbuf)));
+               }
+       }
 
        if (missing_filename)
                ret = build_id_cache__fprintf_missing(session, stdout);