On Fri, May 18, 2018 at 02:46:32PM +0900, Masahiro Yamada wrote:
> Andrew picked it up, but this patch is *bad*
>
> You missed arch/Kconfig.
>
> $(cd "${tree}arch/" && echo *)
> contains Kconfig, but it is not arch.
That was also something that I found a bit weird myself, but I had
assumed there was a good reason for keeping that. The original
command also returns a string containing Kconfig:
> tree="$PWD/"
> echo "$tree"
> ALLSOURCE_ARCHS=""
> for arch in `ls ${tree}arch`; do
> ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS} "${arch##\/}
> done
> echo "$ALLSOURCE_ARCHS"'
gives the same output as my command (albeit with an extra leading
space that shouldn't be important):
> /store/code/projects/kernel/linux/
> Kconfig alpha arc arm arm64 c6x h8300 hexagon ia64 m68k microblaze mips
> nds32 nios2 openrisc parisc powerpc riscv s390 sh sparc um unicore32 x86
> xtensa
However, if there really is no reason for that being there, I
have no complaints against fixing it. I'll send a v3 in a bit.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
