On Tue, 22 May 2018 17:07:53 +0200
Geert Uytterhoeven <geert+rene...@glider.be> wrote:
> The comment about offset zero was not updated when changing behavior:
> - Automatic offset calculation is indicated by OFFSET_CONTINUOUS,
> - Zero really means offset zero.
>
> Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: allow zero offset value")
Did we switch to 16bytes for the short commit ids (I usually use 12
bytes)?
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
> drivers/mtd/cmdlinepart.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
> index fbd5affc0acfe3fe..3ea44cff9b759e3c 100644
> --- a/drivers/mtd/cmdlinepart.c
> +++ b/drivers/mtd/cmdlinepart.c
> @@ -190,7 +190,10 @@ static struct mtd_partition * newpart(char *s,
> extra_mem = (unsigned char *)(parts + *num_parts);
> }
>
> - /* enter this partition (offset will be calculated later if it is zero
> at this point) */
> + /*
> + * enter this partition (offset will be calculated later if it is
> + * OFFSET_CONTINUOUS at this point)
> + */
> parts[this_part].size = size;
> parts[this_part].offset = offset;
> parts[this_part].mask_flags = mask_flags;
