On 05/23/2018 12:07 AM, Andrew Morton wrote: > On Tue, 22 May 2018 22:50:12 +0300 Andrey Ryabinin <[email protected]> > wrote: > >> >> >> On 05/22/2018 07:36 PM, David Hildenbrand wrote: >>> On 22.05.2018 18:26, Andrey Ryabinin wrote: >>>> >>>> >>>> On 05/22/2018 01:07 PM, David Hildenbrand wrote: >>>>> Using module_init() is wrong. E.g. ACPI adds and onlines memory before >>>>> our memory notifier gets registered. >>>>> >>>>> This makes sure that ACPI memory detected during boot up will not >>>>> result in a kernel crash. >>>>> >>>>> Easily reproducable with QEMU, just specify a DIMM when starting up. >>>> >>>> reproducible >>>>> >>>>> Signed-off-by: David Hildenbrand <[email protected]> >>>>> --- >>>> >>>> Fixes: fa69b5989bb0 ("mm/kasan: add support for memory hotplug") >>>> Acked-by: Andrey Ryabinin <[email protected]> >>>> Cc: <[email protected]> >>> >>> Think this even dates back to: >>> >>> 786a8959912e ("kasan: disable memory hotplug") >>> >> >> Indeed. > > Is a backport to -stable justified for either of these patches? >
I don't see any reasons to not backport these. The first one fixes failure to online memory, why it shouldn't be fixed in -stable? The second one is fixes boot crash, it's definitely stable material IMO.
