On Thu, May 24, 2018 at 05:51:34PM +0800, Jianchao Wang wrote: > result = adapter_alloc_sq(dev, qid, nvmeq); > - if (result < 0) > + /* > + * If return -EINTR, it means the allocate sq command times out and is > completed > + * with NVME_REQ_CANCELLED. At the time, the controller has been > disabled > + * and admin request queue has been quiesced. So don't try to send > delete cq > + * command any more. > + */ > + if (result == -EINTR) > + goto out; > + else if (result < 0) > goto release_cq;
Since you're touching this part anyway, you'd really only want to goto the release_cq if result is > 0.
