On Thu, May 24, 2018 at 7:18 AM Mark Brown <broo...@kernel.org> wrote:
> On Wed, May 23, 2018 at 09:17:23AM -0700, Guenter Roeck wrote: > > On Wed, May 23, 2018 at 8:58 AM Mark Brown <broo...@kernel.org> wrote: > > > I'm saying we should move them there. They're clearly part of the > > > userspace ABI and therefore belong in uapi, it was a mistake to let them > > > be elsewhere. > > They define a firmware file format. Not sure if I would call that userspace > > ABI. > It's a binary provided by userspace to the kernel, I'd say that's > clearly an ABI. > > I don't mind adding the structures to > > sound/soc/intel/skylake/skl-tplg-interface.h, > > but it seems a bit out of scope to tie this with moving the file to > > include/uapi/sound. > > I think that should be a separate discussion. > Is there some reason not to just do it while we're looking at this? I > don't see why we wouldn't want to do this. I don't mind doing this. However, keeping the change local and in a single patch would make it easier to backport, and I think that the ability to backport would be essential to get more than one-person test coverage. I also would have liked feedback from someone at Intel, at least for the Skylake specific structures. Anyway, what file do you have in mind for the structure definitions, both for the ones in soc-tolopogy.c and the ones needed in skl-topology.c ? Everything into asoc.h, or something else ? Guenter
