Hi Peter, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Peter-Rosin/rtmutex-allow-specifying-a-subclass-for-nested-locking/20180526-140421 config: x86_64-randconfig-x003-201820 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Peter-Rosin/rtmutex-allow-specifying-a-subclass-for-nested-locking/20180526-140421 HEAD e9f3abe10927b5d6e565ac45d0814e6198b49649 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/i2c/i2c-core-base.c: In function 'i2c_adapter_lock_bus': >> drivers/i2c/i2c-core-base.c:618:2: error: implicit declaration of function >> 'rt_mutex_lock'; did you mean 'rt_mutex_unlock'? >> [-Werror=implicit-function-declaration] rt_mutex_lock(&adapter->bus_lock); ^~~~~~~~~~~~~ rt_mutex_unlock cc1: some warnings being treated as errors -- drivers/i2c/i2c-mux.c: In function 'i2c_mux_lock_bus': >> drivers/i2c/i2c-mux.c:147:2: error: implicit declaration of function >> 'rt_mutex_lock'; did you mean 'rt_mutex_unlock'? >> [-Werror=implicit-function-declaration] rt_mutex_lock(&parent->mux_lock); ^~~~~~~~~~~~~ rt_mutex_unlock cc1: some warnings being treated as errors vim +618 drivers/i2c/i2c-core-base.c 3b5f794b drivers/i2c/i2c-core.c Jean Delvare 2010-06-03 608 9c1600ed drivers/i2c/i2c-core.c David Brownell 2007-05-01 609 /** 8320f495 drivers/i2c/i2c-core.c Peter Rosin 2016-05-04 610 * i2c_adapter_lock_bus - Get exclusive access to an I2C bus segment fe61e07e drivers/i2c/i2c-core.c Jean Delvare 2010-08-11 611 * @adapter: Target I2C bus segment 8320f495 drivers/i2c/i2c-core.c Peter Rosin 2016-05-04 612 * @flags: I2C_LOCK_ROOT_ADAPTER locks the root i2c adapter, I2C_LOCK_SEGMENT 8320f495 drivers/i2c/i2c-core.c Peter Rosin 2016-05-04 613 * locks only this branch in the adapter tree fe61e07e drivers/i2c/i2c-core.c Jean Delvare 2010-08-11 614 */ 8320f495 drivers/i2c/i2c-core.c Peter Rosin 2016-05-04 615 static void i2c_adapter_lock_bus(struct i2c_adapter *adapter, 8320f495 drivers/i2c/i2c-core.c Peter Rosin 2016-05-04 616 unsigned int flags) fe61e07e drivers/i2c/i2c-core.c Jean Delvare 2010-08-11 617 { fe61e07e drivers/i2c/i2c-core.c Jean Delvare 2010-08-11 @618 rt_mutex_lock(&adapter->bus_lock); fe61e07e drivers/i2c/i2c-core.c Jean Delvare 2010-08-11 619 } fe61e07e drivers/i2c/i2c-core.c Jean Delvare 2010-08-11 620 :::::: The code at line 618 was first introduced by commit :::::: fe61e07e9ebc890c70d97a1f72ddaad4bee2d848 i2c: Move adapter locking helpers to i2c-core :::::: TO: Jean Delvare <kh...@linux-fr.org> :::::: CC: Jean Delvare <kh...@linux-fr.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
