On Wed 23 May 07:48 PDT 2018, Sricharan R wrote: > On 5/23/2018 1:07 PM, Vinod wrote: > > On 22-05-18, 23:58, Bjorn Andersson wrote: > >> On Tue 22 May 23:05 PDT 2018, Vinod wrote: > >>> On 22-05-18, 22:20, Bjorn Andersson wrote: [..] > >>> Looking at the patch, few other comments would be applicable too, so > >>> would be > >>> great if you/Sricharan can update this > >>> > >> > >> I agree, the primary purpose of this patch was rather to get feedback on > >> the structure of the drivers, I do expect this to take another round > >> through the editor to get some polishing touches. Sorry if this wasn't > >> clear from the description. > > > > Since Sricharan replied to comments, I though they would be fixed. Yeah > > this is > > fine from RFC.. > > > > Thanks for this. > > Tested this on ipq8074 and wcss rproc is up with this. > > Tested-by: Sricharan R <sricha...@codeaurora.org> >
Thanks Sricharan! > So regarding the cleanup, as i see, this consolidates the code much better. > > so about the point of avoiding duplication for soc specific functions like > qcv5_wcss_reset common between qcv5_wcss and qcv5_pil drivers as done in my > series, with a second thought that feels it might be difficult to maintain > in the longer run. Since the sequences are specific to each soc and for now > although some part of it is common, for a minor update in one soc, common > code needs to reworked every time and tested on all boards that share them. > > So feels like having the duplication for hw init sequences is the cleaner > way. > Sounds good, then let's go with this approach! > Apart from that for other comments on the q6v5 wcss driver, i can address > them > on this final patch that you have posted and same can be included in your > next version. Please let me know how you want to go about it. > If you can help me review the first 4 patches and fix up and resend the 5th that would be greatly appreciated. Regards, Bjorn
