> From: Javier Gonzalez [mailto:jav...@cnexlabs.com]
> This case cannot occur on the only user of the function
> (pblk_recov_l2p()). On the previous check (pblk_line_was_written()), we
> verify the state of the line and the position of the first good chunk. In
> the case of a bad line (less chunks than a given threshold to allow
> emeta), the recovery will not be carried out in the line.
You are right. It looks that during my testing there was some inconsistency 
between chunks state table which is verified inside pblk_line_was_written() and 
blk_bitmap which was read from emeta and is verified in 
pblk_line_smeta_start(). I'm living decision to maintainers whether we should 
keep this sanity check or not - it really just pass gracefully the result from 
pblk_line_smeta_start() where similar sanity check is present.

Igor

Reply via email to