From: Amir Goldstein <[email protected]> Overlayfs should cope with online changes to underlying layer without crashing the kernel, which is what xfstest overlay/019 checks.
This test may sometimes trigger WARN_ON() in ovl_create_or_link() when linking an overlay inode that has been changed on underlying layer. Remove those WARN_ON() to prevent the stress test from failing. Signed-off-by: Amir Goldstein <[email protected]> Signed-off-by: Miklos Szeredi <[email protected]> --- fs/overlayfs/dir.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c index 839709c7803a..01902adc7153 100644 --- a/fs/overlayfs/dir.c +++ b/fs/overlayfs/dir.c @@ -510,13 +510,6 @@ static int ovl_create_or_link(struct dentry *dentry, struct inode *inode, } out_revert_creds: revert_creds(old_cred); - if (!err) { - struct inode *realinode = d_inode(ovl_dentry_upper(dentry)); - - WARN_ON(inode->i_mode != realinode->i_mode); - WARN_ON(!uid_eq(inode->i_uid, realinode->i_uid)); - WARN_ON(!gid_eq(inode->i_gid, realinode->i_gid)); - } return err; } -- 2.14.3
