Hi, On Wed, May 30, 2018 at 2:37 AM, Mark Brown <broo...@kernel.org> wrote: > On Tue, May 29, 2018 at 10:30:33PM -0700, Doug Anderson wrote: >> On Wed, May 23, 2018 at 8:56 AM, Mark Brown <broo...@kernel.org> wrote: > >> > Yes, that's definitely not what's expected but it's unfortunately what >> > the firmware chose to implement so we may well be stuck with it >> > unfortunately. > >> We're not really stuck with it if we do what I was suggesting. I was >> suggesting that every time we disable the regulator in Linux we have >> Linux vote for the lowest voltage it's comfortable with. Linux keeps >> track of the true voltage that the driver wants and will always change >> its vote back to that before enabling. Thus (assuming Linux is OK >> with 1.2 V - 1.4 V for a rail): > > That's pretty much what it should do anyway with normally designed > hardware.
I guess the question is: do we insist that the driver include this workaround, or are we OK with letting the hardware behave as the hardware does? -Doug
