On Wed, May 30, 2018 at 07:04:15PM +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > The addition of the IOCB_CMD_POLL command removed the break > statement for the IOCM_CMD_FDSYNC. From my understanding, this > should not have been removed as the fall-through does not seem > to make sense. Fix this by adding the break back again. > > Detected by CoverityScan, CID#1469469 ("Missing break in switch") > > Fixes: 2c14fa838cbe ("aio: implement IOCB_CMD_POLL") > Signed-off-by: Colin Ian King <[email protected]>
Makes sense to me... Reviewed-by: Darrick J. Wong <[email protected]> --D > --- > fs/aio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/aio.c b/fs/aio.c > index 8274d09d44a2..e0b2f183fa1c 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1785,6 +1785,7 @@ static int io_submit_one(struct kioctx *ctx, struct > iocb __user *user_iocb, > break; > case IOCB_CMD_FDSYNC: > ret = aio_fsync(&req->fsync, iocb, true); > + break; > case IOCB_CMD_POLL: > ret = aio_poll(req, iocb); > break; > -- > 2.17.0 >
