On Fri, 01 Jun 2018 15:34:33 +0200 Stefan Agner <ste...@agner.ch> wrote:
> On 01.06.2018 11:25, Boris Brezillon wrote: > > On Fri, 1 Jun 2018 09:26:00 +0200 > > Boris Brezillon <boris.brezil...@bootlin.com> wrote: > > > >> On Fri, 1 Jun 2018 00:16:32 +0200 > >> Stefan Agner <ste...@agner.ch> wrote: > >> > >> > Add Reed-Solomon (RS) to the enumeration of ECC algorithms. > >> > > >> > Signed-off-by: Stefan Agner <ste...@agner.ch> > >> > >> Reviewed-by: Boris Brezillon <boris.brezil...@bootlin.com> > >> > >> > --- > >> > drivers/mtd/nand/raw/nand_base.c | 1 + > >> > include/linux/mtd/rawnand.h | 1 + > > > > Hm, you forgot to update Documentation/devicetree/bindings/mtd/nand.txt. > > > > Yeah I was not sure about that. Currently it says: > > - nand-ecc-algo: string, algorithm of NAND ECC. > > Supported values are: "hamming", "bch". > > Is supported meant by software ECC here? I feel "supported" is a rather > strong word since it is clearly controller dependent whether it is > actually supported... I guess "valid values" or "accepted values" would be more appropriate here.
