On Tue, May 29, 2018 at 04:43:35PM +0100, Mark Rutland wrote:
> /**
> + * atomic64_add_unless - add unless the number is already a given value
> + * @v: pointer of type atomic_t
> + * @a: the amount to add to v...
> + * @u: ...unless v is equal to u.
> + *
> + * Atomically adds @a to @v, so long as @v was not already @u.
> + * Returns non-zero if @v was not @u, and zero otherwise.
I always get confused by that wording; would something like: "Returns
true if the addition was done" not be more clear?
> + */
> +#ifdef atomic64_fetch_add_unless
> +static inline int atomic64_add_unless(atomic64_t *v, long long a, long long
> u)
Do we want to make that a "bool' return?
> +{
> + return atomic64_fetch_add_unless(v, a, u) != u;
> +}
> +#endif
