Commit-ID:  a84277bf3efcc7bb5b5a5eec62de5c134cb47ee5
Gitweb:     https://git.kernel.org/tip/a84277bf3efcc7bb5b5a5eec62de5c134cb47ee5
Author:     Arnd Bergmann <[email protected]>
AuthorDate: Tue, 5 Jun 2018 13:43:34 +0200
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Wed, 6 Jun 2018 12:05:19 +0200

irqchip/stm32: Fix non-SMP build warning

A CONFIG_SMP=n build emits a harmless compile-time warning:

drivers/irqchip/irq-stm32-exti.c:495:12: error: 'stm32_exti_h_set_affinity' 
defined but not used [-Werror=unused-function]

The #ifdef is inconsistent here, and it's better to use an IS_ENABLED() check
that lets the compiler silently drop that function.

Fixes: 927abfc4461e ("irqchip/stm32: Add stm32mp1 support with hierarchy 
domain")
Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Ludovic Barre <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Benjamin Gaignard <[email protected]>
Cc: Radoslaw Pietrzyk <[email protected]>
Cc: Jason Cooper <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: [email protected]
Cc: Maxime Coquelin <[email protected]>
Cc: Alexandre Torgue <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]

---
 drivers/irqchip/irq-stm32-exti.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index 5089c1e2838d..3a7e8905a97e 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -552,9 +552,7 @@ static struct irq_chip stm32_exti_h_chip = {
        .irq_set_type           = stm32_exti_h_set_type,
        .irq_set_wake           = stm32_exti_h_set_wake,
        .flags                  = IRQCHIP_MASK_ON_SUSPEND,
-#ifdef CONFIG_SMP
-       .irq_set_affinity       = stm32_exti_h_set_affinity,
-#endif
+       .irq_set_affinity       = IS_ENABLED(CONFIG_SMP) ? 
stm32_exti_h_set_affinity : NULL,
 };
 
 static int stm32_exti_h_domain_alloc(struct irq_domain *dm,

Reply via email to