Hi Ricardo,
> Export serdev table to the module header, allowing module autoload via
> udev/modprobe.
>
> Cc: Marcel Holtmann <mar...@holtmann.org>
> Cc: Johan Hedberg <johan.hedb...@gmail.com>
> Cc: Rob Herring <r...@kernel.org>
> Cc: Johan Hovold <jo...@kernel.org>
> Cc: linux-blueto...@vger.kernel.org
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
> ---
> drivers/bluetooth/hci_bcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index f4d7846c06b8..ff0fd3502a90 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1327,8 +1327,10 @@ MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
>
> static const struct serdev_device_id bcm_serdev_id[] = {
> { "bcm43438-bt", },
> + { "hci_uart_bcm", },
> {}
> };
> +MODULE_DEVICE_TABLE(serdev, bcm_serdev_id);
so this one I can see real use of and is a good fix to finally clean up
hci_bcm.c and remove platform support for the Edison hardware. However, I would
really then first rename hci_uart_bcm into some Edison specific string since
this is really just one outlier here. Everything else will have ACPI or DT
support.
With that said, I do not understand why we need to duplicate the DT compatible
strings in serdev_device_id. They will be enumerated fine via ACPI or DT in the
first place. So if we want some new_id support, then wouldn’t an empty
serdev_device_id table just be fine?
Regards
Marcel
