On Tue, Jun 12, 2018 at 11:31 AM, Geert Uytterhoeven <[email protected]> wrote: > On Mon, Jun 11, 2018 at 11:03 PM Andy Shevchenko > <[email protected]> wrote: >> On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <[email protected]> wrote: >> > This patch fix the following build error on M68K: > > Not plain m68k, but coldfire only (and MIPS AR7, I guess). > >> > drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios': >> > 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate' >> > 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate' >> > >> > So 8250_dw need to depend on COMMON_CLK. >> > >> >> Makes sense. >> Reviewed-by: Andy Shevchenko <[email protected]> > > Please see "[PATCH 0/3] Legacy clock drivers: Normalize clk API" > (https://lkml.org/lkml/2018/6/11/122).
Indeed, your solution is better. So, I need to withdraw my tag. -- With Best Regards, Andy Shevchenko
