On Wed, 13 Jun 2018 14:17:07 +0200 Juri Lelli <[email protected]> wrote:
> From: Mathieu Poirier <[email protected]> > > The comment above function partition_sched_domains() clearly state that > the cpu_hotplug_lock should be held but doesn't mandate one to abide to > it. > > Add an explicit check backing that comment, so to make it impossible > for anyone to miss the requirement. > > Suggested-by: Juri Lelli <[email protected]> > Signed-off-by: Mathieu Poirier <[email protected]> > [modified changelog] > Signed-off-by: Juri Lelli <[email protected]> Reviewed-by: Steven Rostedt (VMware) <[email protected]> -- Steve > --- > kernel/sched/topology.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 61a1125c1ae4..96eee22fafe8 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -1858,6 +1858,7 @@ void partition_sched_domains(int ndoms_new, > cpumask_var_t doms_new[], > int i, j, n; > int new_topology; > > + lockdep_assert_cpus_held(); > mutex_lock(&sched_domains_mutex); > > /* Always unregister in case we don't destroy any domains: */
