On 19/06/18 01:15, Miquel Raynal wrote: > Hi Chris, > > On Mon, 18 Jun 2018 16:52:53 +1200, Chris Packham > <chris.pack...@alliedtelesis.co.nz> wrote: > >> Hi, >> >> I'm looking at adding support for the Micron MT29F1G08ABAFAWP-ITE:F chip >> to one of our boards which uses the Marvell NFCv2 controller. >> >> This particular chip is a bit odd in that the datasheet states support >> for ONFI 1.0 but the revision number field is 00 00. It also is marked >> ABAFA but reports internally as ABAGA. Finally it has internal 8-bit ECC >> which cannot be disabled. > > Boris and I agree that in this case, the chip should not be probed if > ecc->type != ON_DIE (and eventually NONE). > > This should be handled in the Micron driver. > > Also, what is the returned value of micron_supports_on_die_ecc() (with > patch 1/2)?
micron_supports_on_die_ecc() returns MICRON_ON_DIE_UNSUPPORTED. Technically this chip should be MICRON_ON_DIE_MANDATORY since it can't be disabled but that wouldn't be much help since that would still result in -EINVAL. I'll dig into micron_supports_on_die_ecc() and see if I can find something in the datasheet to use. > > Regards, > Miquèl >
