The function tick_clear() checks if the timer is active and in this case cancels the timer. However, hrtimer_cancel does the same check.
Perhaps, this test is made on purpose to skip some function calls for efficiency reasons but if it is not the case we can safely remove it. Signed-off-by: Daniel Lezcano <[email protected]> --- kernel/sched/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index d155518..aa46aa6 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -218,8 +218,7 @@ void update_rq_clock(struct rq *rq) static void hrtick_clear(struct rq *rq) { - if (hrtimer_active(&rq->hrtick_timer)) - hrtimer_cancel(&rq->hrtick_timer); + hrtimer_cancel(&rq->hrtick_timer); } /* -- 2.7.4
