On Tue, Jun 19, 2018 at 04:34:33PM +0200, Miklos Szeredi wrote: > On Tue, Jun 19, 2018 at 4:24 PM, Christoph Hellwig <[email protected]> wrote: > > On Tue, Jun 19, 2018 at 04:04:41PM +0200, Miklos Szeredi wrote: > >> FS_IOC* > >> > >> Haven't looked deeply. For now overlayfs just implements > >> FS_IOC_{GET|SET}FLAGS because some of these flags are quite generic > >> and implementing them on the overlay is easy. > >> > >> Yes, turning into a method makes sense. > > > > Do you want to do this or should I send a patch? > > Do it. You are much more familiar with regular fs that implement > these ioctls. Untangling overlap between FS_IOC_...FLAGS and > FS_IOC_...XATTR looks "interesting".
Suggestion: have that go through ->setattr(); that's what ATTR_ATTR_FLAG was supposed to be for, IIRC.
