Hi Vlastimil,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.18-rc1 next-20180619]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Vlastimil-Babka/kmalloc-reclaimable-caches/20180618-172912
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging//android/ion/ion_page_pool.c: In function 
'ion_page_pool_remove':
>> drivers/staging//android/ion/ion_page_pool.c:56:40: error: 
>> 'NR_INDIRECTLY_RECLAIMABLE_BYTES' undeclared (first use in this function)
     mod_node_page_state(page_pgdat(page), NR_INDIRECTLY_RECLAIMABLE_BYTES,
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging//android/ion/ion_page_pool.c:56:40: note: each undeclared 
identifier is reported only once for each function it appears in

vim +/NR_INDIRECTLY_RECLAIMABLE_BYTES +56 
drivers/staging//android/ion/ion_page_pool.c

0214c7f2 Rebecca Schultz Zavin 2013-12-13  40  
0fb9b815 Rebecca Schultz Zavin 2013-12-13  41  static struct page 
*ion_page_pool_remove(struct ion_page_pool *pool, bool high)
0214c7f2 Rebecca Schultz Zavin 2013-12-13  42  {
0214c7f2 Rebecca Schultz Zavin 2013-12-13  43   struct page *page;
0214c7f2 Rebecca Schultz Zavin 2013-12-13  44  
0fb9b815 Rebecca Schultz Zavin 2013-12-13  45   if (high) {
0fb9b815 Rebecca Schultz Zavin 2013-12-13  46           
BUG_ON(!pool->high_count);
38c003b1 Heesub Shin           2014-05-28  47           page = 
list_first_entry(&pool->high_items, struct page, lru);
0fb9b815 Rebecca Schultz Zavin 2013-12-13  48           pool->high_count--;
0fb9b815 Rebecca Schultz Zavin 2013-12-13  49   } else {
0fb9b815 Rebecca Schultz Zavin 2013-12-13  50           
BUG_ON(!pool->low_count);
38c003b1 Heesub Shin           2014-05-28  51           page = 
list_first_entry(&pool->low_items, struct page, lru);
0fb9b815 Rebecca Schultz Zavin 2013-12-13  52           pool->low_count--;
0fb9b815 Rebecca Schultz Zavin 2013-12-13  53   }
0214c7f2 Rebecca Schultz Zavin 2013-12-13  54  
38c003b1 Heesub Shin           2014-05-28  55   list_del(&page->lru);
06cd8a61 Andrew Morton         2018-06-15 @56   
mod_node_page_state(page_pgdat(page), NR_INDIRECTLY_RECLAIMABLE_BYTES,
06cd8a61 Andrew Morton         2018-06-15  57                       -(1 << 
(PAGE_SHIFT + pool->order)));
0214c7f2 Rebecca Schultz Zavin 2013-12-13  58   return page;
0214c7f2 Rebecca Schultz Zavin 2013-12-13  59  }
0214c7f2 Rebecca Schultz Zavin 2013-12-13  60  

:::::: The code at line 56 was first introduced by commit
:::::: 06cd8a610861a7ea0be1ff627fd8d6d6b3f62ca0 origin

:::::: TO: Andrew Morton <a...@linux-foundation.org>
:::::: CC: Johannes Weiner <han...@cmpxchg.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to