On 20/06/18 19:47, Boris Brezillon wrote: > Hi Chris, > > On Wed, 20 Jun 2018 17:05:41 +1200 > Chris Packham <chris.pack...@alliedtelesis.co.nz> wrote: > >> From the controllers point of view this is the same as no or >> software only ECC. >> >> Reviewed-by: Boris Brezillon <boris.brezil...@bootlin.com> > > I'm nitpicking, but we usually put the R-b/A-b tags after the author > SoB.
Yeah sorry force of habit from using gerrit internally. I'll try to re-train my fingers. >> Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> >> --- >> Changes in v2: >> - New >> Changes in v3: >> - Add review from Boris >> >> drivers/mtd/nand/raw/marvell_nand.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/nand/raw/marvell_nand.c >> b/drivers/mtd/nand/raw/marvell_nand.c >> index ebb1d141b900..ba6889bbe802 100644 >> --- a/drivers/mtd/nand/raw/marvell_nand.c >> +++ b/drivers/mtd/nand/raw/marvell_nand.c >> @@ -2157,6 +2157,7 @@ static int marvell_nand_ecc_init(struct mtd_info *mtd, >> break; >> case NAND_ECC_NONE: >> case NAND_ECC_SOFT: >> + case NAND_ECC_ON_DIE: >> if (!nfc->caps->is_nfcv2 && mtd->writesize != SZ_512 && >> mtd->writesize != SZ_2K) { >> dev_err(nfc->dev, "NFCv1 cannot write %d bytes pages\n", > >