On Monday 18 June 2007, Andrew Morton wrote: > Also, your changelog sucks: > > This updates scripts/hdrschecks.sh by grepping for asm() constructs and > rejecting them in favor of __asm__() in exported headers. > > well OK. But for what reason? We can see a lot of pain in this patch but > no gain. The changelog should tell us what the benefit is, so we can make > informed tradeoff decisions.
err, should have included the rationale in previous e-mail ... we want to audit asm/volatile because both constructs will fail in userland builds when GNU extensions are turned off (like -std=c99) ... __asm__ and __volatile__ will work in both places. -mike
signature.asc
Description: This is a digitally signed message part.
