On Sun, 24 Jun 2018, David Howells wrote:
> Thomas Gleixner <[email protected]> wrote:
>
> > - Stick the struct into the local header file and not at some random place
> > in
> > the source.
>
> Why? It's only used in that one file. There doesn't seem to be any
> particular need to share it around.
It's not in a global header. It's a local header exactly to stick stuff
like that into it.
> > - Get rid of the fugly camel case
>
> It's not camel case. It's the name of the option it's encoding. But if it
> makes you happy...
Well, the option name slipped through, but that doesn't make an excuse for
making the struct member equally ugly.
Thanks,
tglx