On Tue, 2018-06-26 at 15:11 +0800, Chiang, AlanX wrote:
> If it is, I would like to modify it as below:
>
> case 8:
> If (chip->flags & AT24_FLAG_ADDR16) {
> chip->flags &= ~AT24_FLAG_ADDR16;
> dev_warn(dev, "address-width is 8, clear the ADDR16
> bit\n");
> }
> break;
No need to put bit clearing inside the loop, something like below would
be slightly better.
if (chip->flags & AT24_FLAG_ADDR16)
dev_warn(dev, "address-width is 8, clear the ADDR16 bit\n");
chip->flags &= ~AT24_FLAG_ADDR16;
On top of this the message would sound clearer if you put it like
"Override address width to be 8, while default is 16"
--
Andy Shevchenko <[email protected]>
Intel Finland Oy
