On Mon, Jun 25, 2018 at 5:54 PM, Gustavo A. R. Silva <[email protected]> wrote: > > > On 06/25/2018 06:06 PM, Kees Cook wrote: >> On Mon, Jun 25, 2018 at 2:23 PM, Joe Perches <[email protected]> wrote: >>> warning-3 += -Wswitch-default >> >> This reminds me, though. Should _this_ one get moved to warning-1? >> >> $ git log next-20180625 --no-merges --grep 'mark expected switch >> fall-through' --oneline | wc -l >> 129 >> >> Gustavo, have you checked recently how many of these are left? Maybe >> we can move this to default too? >> > > I just built today's kernel and we have a total of 704 fall-through warnings > with -Wimplicit-fallthrough=2
Wow; that's still a lot! > I think we might be able to do that in this development cycle. Do you think we could finish the rest of the unannotated ones this cycle? If not, we could upgrade from W=3 to W=1 since it's a condition we're actively trying to remove from the kernel... -Kees -- Kees Cook Pixel Security
