Anson Huang Best Regards!
> -----Original Message----- > From: Fabio Estevam [mailto:[email protected]] > Sent: Wednesday, June 27, 2018 9:21 AM > To: Anson Huang <[email protected]> > Cc: Shawn Guo <[email protected]>; Sascha Hauer > <[email protected]>; Sascha Hauer <[email protected]>; Fabio > Estevam <[email protected]>; Rob Herring <[email protected]>; > Mark Rutland <[email protected]>; dl-linux-imx <[email protected]>; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > <[email protected]>; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS <[email protected]>; > linux-kernel <[email protected]> > Subject: Re: [PATCH] ARM: dts: make pfuze switch always-on for imx platforms > > On Tue, Jun 26, 2018 at 3:08 AM, Anson Huang <[email protected]> > wrote: > > commit (5fe156f regulator: pfuze100: add enable/disable for switch) > > will cause those unreferenced switches being > > Nit: The proper way to reference a commit is: > > commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch") > > 12 char for the commit ID and the commit name inside (" "). > > > turned off if "regulator-always-on" is NOT present, as pfuze switches > > are normally used by critical modules which must be always ON or > > shared by many peripherals which do NOT implement power domain > > control, so just make sure all switches always ON to avoid any system > > issue caused by unexpectedly turning off switches. > > > > Signed-off-by: Anson Huang <[email protected]> > > Reviewed-by: Fabio Estevam <[email protected]> Thanks, will improve it and also the other patch for imx6sll. Anson.
