On Wed, 27 Jun 2018 22:47:44 +0200
Martin Kaiser <mar...@kaiser.cx> wrote:
> Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can
> potentially be called at any time. After the __init functions are cleaned,
> mxcnd_probe_dt is no longer available. Calling it anyway causes a crash.
>
> mxcnd_probe used to be marked as __init, this was removed years ago.
> Remove the __init qualifier from from mxcnd_probe_dt as well.
>
> Fixes: 06f255106923 ("mtd: remove use of __devinit")
> Signed-off-by: Martin Kaiser <mar...@kaiser.cx>
Reviewed-by: Boris Brezillon <boris.brezil...@bootlin.com>
> ---
> changes in v3
> - show the first 12 characters of the SHA-1 ID in the Fixes: tag
>
> changes in v2
> - rephrased the commit message
> - added a Fixes: tag
>
> drivers/mtd/nand/raw/mxc_nand.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
> index 26cef218bb43..90cfb5e730aa 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1686,7 +1686,7 @@ static const struct of_device_id mxcnd_dt_ids[] = {
> };
> MODULE_DEVICE_TABLE(of, mxcnd_dt_ids);
>
> -static int __init mxcnd_probe_dt(struct mxc_nand_host *host)
> +static int mxcnd_probe_dt(struct mxc_nand_host *host)
> {
> struct device_node *np = host->dev->of_node;
> const struct of_device_id *of_id =
> @@ -1700,7 +1700,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host
> *host)
> return 0;
> }
> #else
> -static int __init mxcnd_probe_dt(struct mxc_nand_host *host)
> +static int mxcnd_probe_dt(struct mxc_nand_host *host)
> {
> return 1;
> }
