Hi Linux, Thanks for the review.
> -----Original Message----- > From: Linus Walleij [mailto:[email protected]] > Sent: Thursday, June 28, 2018 12:19 PM > To: Naga Sureshkumar Relli <[email protected]> > Cc: Boris Brezillon <[email protected]>; Richard Weinberger > <[email protected]>; > David Woodhouse <[email protected]>; Brian Norris > <[email protected]>; Mark Vasut <[email protected]>; Florian > Fainelli > <[email protected]>; Markus Mayer <[email protected]>; Roger Quadros > <[email protected]>; Ladislav Michl <[email protected]>; [email protected]; > [email protected]; Miquèl Raynal <[email protected]>; linux- > [email protected]; [email protected]; > [email protected]; > Michal Simek <[email protected]> > Subject: Re: [[LINUX PATCH v10] 2/4] memory: pl353: Add driver for arm pl353 > static > memory controller > > On Thu, Jun 21, 2018 at 8:43 AM Naga Sureshkumar Relli > <[email protected]> wrote: > > > Add driver for arm pl353 static memory controller. This controller is > > used in Xilinx Zynq SoC for interfacing the NAND and NOR/SRAM memory > > devices. > > > > Signed-off-by: Naga Sureshkumar Relli > > <[email protected]> > > (...) > > > +config PL353_SMC > > + tristate "ARM PL35X Static Memory Controller(SMC) driver" > > + default y > > + depends on ARM > > + depends on ARCH_ZYNQ > > depends on ARM_AMBA Ok. I will add it next version. > > > +#include <linux/platform_device.h> > > This is a PrimeCell with the ARM primecell ID registers specified, so it > should not use > platform device. Thanks for pointing these drivers. Let me go through these. > > Use <linux/amba/bus.h> > > It further needs to match on these magic values (found in > 0xfe0 etc) and use the name "apb_pclk" for the peripheral > (silicon) clock. > > See examples such as: > drivers/mmc/host/mmci.c > drivers/tty/serial/amba-pl011.c > drivers/video/fbdev/amba-clcd.c > drivers/hwtracing/coresight/* > etc for examples. > > Also see and reference the special PrimeCell DT bindings: > Documentation/devicetree/bindings/arm/primecell.txt Ok. I will go through these bindings once. > > Yours, > Linus Walleij Thank for your review. Regards, Naga Sureshkumar Relli.
