On Thu, Jun 28, 2018 at 05:34:07PM +0300, Sagi Grimberg wrote: > > > Thinking more on this, not using the hw qid really limits the utility > > out of using these trace events: We may not be able to match a completion > > to the submission without it since cmdid alone isn't enough to match up > > the two events. > > > > Here's an updated proposal and actually tested. I was also able to > > combine admin and io submissions. > > This looks good! > > One thing that is missing is the controller id when we have multiple > controllers/subsystems in the host like: > > TP_printk("nvme%d: qid=%d, nsid=%u, cmdid=%u, flags=0x%x, meta=0x%llx, > cmd=(%s %s)", > > But Johannes can add it I guess.
Yep, I'm sort of going off on a tangent from what Johannes was adding. We definitely need both. I have some time today, I'll send out the a series with the combined results.