On Sat, Jun 23, 2018 at 11:05 PM Teika Kazura <te...@gmx.com> wrote:
>
> Hi, Rosen. Thank you for your patch. (@Jan Steffens and @Pablo Cholaky:
> Thanks for your reports.) But I'm afraid some more work is necessary. Let me
> propose some points.
Too much work for me. I'll just use the kernel pareameter.
>
> I'm not a kernel developer, but have been working on this issue to help them.
> (See https://www.spinics.net/lists/linux-input/msg55950.html )
>
> 0.
> Could you resend it, cc-ing to the relevant developers. (Use the one of my
> reply here. You can use <kernel src tree>/scripts/get_maintainer.pl next
> time.) Otherwise, it is unlikely to be noticed by them.
>
> 1.
> You added your device to forcepad_pnp_ids[], but I guess it should be
> smbus_pnp_ids[].
>
> When making the patch again, please use the kernel 4.17 or newer, because
> smbus_pnp_ids was changed recently.
>
> If it works by using smbus_pnp_ids, please test it for a week or so,
> especially making sure that suspend/resume works without any problem.
>
> 2.
> Though it's my personal impression, the change description looked somewhat
> personal. At the same time, it's important, guaranteeing the stability of the
> patch.- I know you originally reported it last August [1]. Furthermore, there
> have been two other users [2] who reported SMBus worked for the same device,
> namely SYN1219. (They two are cc-ed to in this reply.)
>
> You can use "$ git format-patch --cover-letter"; it will generate a
> "cover-letter", the introductory part of the patch, explaining the
> acceptability of the patch to kernel developers. (For an example, see
> https://www.spinics.net/lists/linux-input/msg57041.html)
>
> So the full description can be given in the cover letter, and the real patch
> description can be something like "This enables SMBus for xxx", being almost
> identical to the email subject.
>
> 3. This is not essential, but the style of the email subject that the device
> maintainer prefers might be:
> ------------------------------------------------------------------------
> [PATCH v2] Input: synaptics - Enable RMI4 for Clevo P870DM laptops
> ------------------------------------------------------------------------
> after looking at this tree [3]. ("v2" meaning version 2, due to the above
> change.) You can feed "--subject-prefix='PATCH v2'" to "$ git format-patch".
>
> 4. If you want to give the credit for my reply, you can add
> ------------------------------------------------------------------------
> Suggested-by: Teika Kazura <te...@gmx.com>
> ------------------------------------------------------------------------
> after Signed-off-by. It's completely ok without it. :-)
>
> [1] https://marc.info/?l=linux-input&m=150284057602358&w=2
> [2] https://marc.info/?l=linux-input&m=150049625613055&w=2
> https://marc.info/?l=linux-input&m=150094561111026&w=2
> [3] https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/log/
>
> Best regards,
> Teika (Teika kazura)
>
>
> From: Rosen Penev <ros...@gmail.com>
> Subject: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
> Date: Sat, 16 Jun 2018 18:42:16 -0700
>
> > I have been testing this for half a year with no issues to report.
> >
> > Signed-off-by: Rosen Penev <ros...@gmail.com>
> > ---
> > drivers/input/mouse/synaptics.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/mouse/synaptics.c
> > b/drivers/input/mouse/synaptics.c
> > index 55d33500d55e..23f5bb2cf9da 100644
> > --- a/drivers/input/mouse/synaptics.c
> > +++ b/drivers/input/mouse/synaptics.c
> > @@ -183,6 +183,7 @@ static const char * const smbus_pnp_ids[] = {
> > };
> >
> > static const char * const forcepad_pnp_ids[] = {
> > + "SYN1219",
> > "SYN300D",
> > "SYN3014",
> > NULL
> > --
> > 2.17.1
> >
