On Tue, 2018-07-03 at 10:48 +0800, Jisheng Zhang wrote: > On Tue, 3 Jul 2018 10:22:57 +0800 Jisheng Zhang wrote:
> patching struct uart_port seems a bit overhead. After reading the code > again, I propose another solution, similar as what dl_write() is used > in > 8250 core: > > 1.introduce the hook to struct uart_8250_port as my previous patches > do, > > 2.rename current serial8250_set_divisor() as > default_serial_get_divisor() > then introduce a new serial8250_set_divisor() as: > static inline void serial8250_set_divisor(struct uart_8250_port > *up,....) > { > up->set_divisor(); > } > > and point up->set-divisor to default_serial_get_divisor > > what do you think about this solution? Disagree. See my previous answer for details. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy